Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Visualize the resizer #28264

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 3, 2024

With this PR: resizer will be visualized on hover/dragging; debounced by 0.1s to avoid flicking when user pointer moves too fast from one side to another.

resizer.mp4

Preview: https://raw.githack.com/ycw/three.js/editor-toggle-resizer-vis/editor/index.html

@Mugen87
Copy link
Collaborator

Mugen87 commented May 3, 2024

I'm not sure about this PR. This change feels a bit like an optional gimmick. Because of the minimalistic style of the editor, I would probably leave this one out.

@ycw
Copy link
Contributor Author

ycw commented May 3, 2024

closed. reason: minimalistic style required

@ycw ycw closed this May 3, 2024
@ycw ycw deleted the editor-toggle-resizer-vis branch May 3, 2024 09:42
@Mugen87 Mugen87 added this to the r165 milestone May 3, 2024
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2024

I actually like it. But seems like this ycw:editor-toggle-resizer-vis branch is gone and can't reopen and merge...

@ycw ycw restored the editor-toggle-resizer-vis branch May 17, 2024 11:55
@ycw
Copy link
Contributor Author

ycw commented May 17, 2024

ok

@mrdoob mrdoob reopened this May 17, 2024
@mrdoob mrdoob merged commit cb24e42 into mrdoob:dev May 17, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants