Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Update copyFramebufferToTexture function signature #28329

Merged
merged 2 commits into from
May 10, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #28281 #28315

Description
This PR update the function signature of copyFramebufferToTexture to align with the new copyTextureToTexture and copyTextureToTexture3D.

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r165 milestone May 10, 2024
Copy link

github-actions bot commented May 10, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.5 kB (168.1 kB) 678.6 kB (168.1 kB) +179 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.6 kB (110.4 kB) 457.8 kB (110.4 kB) +179 B

@Mugen87 Mugen87 merged commit a2f0682 into mrdoob:dev May 10, 2024
12 checks passed
davcri added a commit to davcri/react-postprocessing that referenced this pull request Jul 17, 2024
`copyFramebufferToTexture()` changed its signature in r165 mrdoob/three.js#28329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants