Editor: Enhance SetValueCommand to support nested attributeName #28602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #28601
This PR enhances
SetValueCommand
to support nestedattributeName
, s.t. editor will dispatch objectChanged onobject
(which is the selected object), notobject.shadow
(which can never be a selected object) ...... which in turn UI will get refresh:
three.js/editor/js/Sidebar.Object.js
Lines 733 to 739 in 8eccd73
Preview: https://raw.githack.com/ycw/three.js/editor-setvaluecommand-attributename-supports-nested-props/editor/index.html
Test file: File>Open project.json
Test:
SetValueCommand.supports.nested.properties.mp4