Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light: Ensure target can be serialized/deserialized. #28696

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 18, 2024

Related issue: #14658 (comment)

Description

This PR ensures light targets can be serialized/deserialized.

The assumption of this PR is that the target is part of the scene graph.

Copy link

github-actions bot commented Jun 18, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.4 kB (168.3 kB) 679.7 kB (168.4 kB) +294 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.4 kB (110.4 kB) 457.4 kB (110.4 kB) +0 B

@Mugen87 Mugen87 added this to the r166 milestone Jun 19, 2024
@Mugen87 Mugen87 merged commit 6ea0fb9 into mrdoob:dev Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant