Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix texture matrix reference #28801

Merged
merged 3 commits into from
Jul 4, 2024
Merged

TSL: Fix texture matrix reference #28801

merged 3 commits into from
Jul 4, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 4, 2024

Related issue: Closes #28758

Description

The matrix reference was lost when the texture was replaced by another one in the reference() node, this ensures that the matrix is ​​updated when the texture is updated.

@sunag sunag added this to the r167 milestone Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.4 kB (169.2 kB) 683.4 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.6 kB (111.1 kB) 460.6 kB (111.1 kB) +0 B

@sunag sunag marked this pull request as ready for review July 4, 2024 06:18
@sunag sunag merged commit a6f87ff into mrdoob:dev Jul 4, 2024
12 checks passed
@sunag sunag deleted the dev-gltf-test branch July 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGLRenderer replaces WebGPURenderer texture exceptions
1 participant