Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Support to dynamic light.castShadow #28945

Merged
merged 2 commits into from
Jul 23, 2024
Merged

WebGPURenderer: Support to dynamic light.castShadow #28945

merged 2 commits into from
Jul 23, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 23, 2024

Related issue: #28926

@sunag sunag added this to the r167 milestone Jul 23, 2024
@sunag sunag marked this pull request as ready for review July 23, 2024 15:52
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

Mugen87
Mugen87 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with webgpu_postprocessing_pixel and it works great!

@sunag sunag merged commit e275bcf into mrdoob:dev Jul 23, 2024
12 checks passed
@sunag sunag deleted the dev-light-castshadow branch July 23, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @Mugen87