WebGPURenderer: Add debug.getRawShaderAsync().
#28997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Jul 27, 2024
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Jul 27, 2024
sunag
changed the title
debug.getRawShader().debug.getRawShaderAsync().
|
@sunag Nice solution! 🙌 |
brunosimon
pushed a commit
to brunosimon/three.js
that referenced
this pull request
Jul 28, 2024
* WebGPURenderer: Add `debug.getRawShader()`. * Added getRawShaderAsync() --------- Co-authored-by: sunag <sunagbrasil@gmail.com>
|
Maybe |
Mugen87
changed the title
debug.getRawShaderAsync().debug.getShaderAsync().
Mugen87
changed the title
debug.getShaderAsync().debug.getRawShaderAsync().
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28984.
Description
This PR fixes
webgpu_tsl_editorby addingrendererer.debug.getRawShader()which allows to get the raw shader (WGSL or GLSL) for a 3D object.