Nodes: StereoCompositePassNode.js #29201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitePassNode class to reuse shared functionality
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Huh, webgpu_backdrop_water is still failing. |
Mugen87
reviewed
Aug 22, 2024
Mugen87
approved these changes
Aug 22, 2024
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #29184
Description
Creates a class StereoCompositePassNode.js that implements functionality shared between AnaglyphPassNode and ParallaxBarrierPassNode.js. Anaglyph and ParallaxBarrier now implement this class.
Additionally, I modified the webgpu_stereo_camera.html example slightly. Now, the user can modify the eyeSep value, demonstrating how this value affects the final output of the image.