OutlinePass: Improve performance of VisibilityChangeCallBack().
#29220
+31
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations with a lot of objects.
Barokoli
changed the title
Clean up.
Mugen87
reviewed
Aug 23, 2024
Mugen87
changed the title
VisibilityChangeCallBack().
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mugen87
reviewed
Aug 26, 2024
Clean up.
Refactor selection cache.
This was referenced Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During performance profiling i found that having selections with 500+ meshes where resulting in ~7ms twice per frame in the changeVisibilityOfNonSelectedObjects function due to the for loop and array setup.
I replaced the array with a set and now the function takes <1ms.
Thanks for the great library!