sea3d revision 3 - optimized #7096
Conversation
|
|
||
| // SEA3D | ||
|
|
||
| this.file.typeRead[ SEA3D.Geometry.prototype.type ] = |
There was a problem hiding this comment.
I think you're missing the other side of the equality here?
There was a problem hiding this comment.
Ah wait. You are assigning the result from the next line 😮
There was a problem hiding this comment.
Is this safe? See the other comment.
There was a problem hiding this comment.
See point 2 of the answer to this so question
Not sure if it applies to this situation, and if it is still accurate info.
There was a problem hiding this comment.
Seems like I was wrong. This kind of assignment is valid (atleast in chrome)
There was a problem hiding this comment.
JavaScript compilers should turn into Tokens line break, tabs and traditional space in the same class.
Line 262: isWhitespace https://github.com/google/closure-compiler/blob/0c09d82ab71f5518d6334692d279615e59c2b455/src/com/google/javascript/jscomp/parsing/parser/Scanner.java
Other compilers like AS3 of Adobe by Jeff Dyer and other parser of AS3 by Victor Dramba use the same hierarchy.
|
Nice! Thanks! |
|
You should remove the call to |
Hi. I made a version of SEA3D optimized for the Three.JS improving the performance all in THREE.BufferGeometry r72 and some new features.
http://community.poonya.com/160
Fixes #6914
Cheers.