Change *IdCount functions back to variables #9558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "modules" pull request changed variables such as THREE.GeometryIdCount to functions, which didn't make a whole lot of sense to me.
|
They could even be private in its own module. Unfortunately |
|
So what is stopping this pull request, exactly (besides that it now has a conflict?) I was also thinking that it may be useful for debugging purposes to keep the properties public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "modules" pull request changed variables such as
THREE.GeometryIdCountto functions which incremented the internal variable with one.Such functions didn't make a whole lot of sense to me, so I changed it.