-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: specify pnpm version in package json #1676
Conversation
@bartektelec, we need to lock PNPM version to the one used on the CI to make sure builds are passing (lock mismatches due to PNPM version mismatches throw): Lines 24 to 26 in e87e00b
If the sandbox is using an older/newer version, it likely has to be pinned to but we don't have to solve it. The need to have a stable version is to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this! I left a few suggestions on how to make a new contributing experience a bit more streamlined in regards to the correct PNPM version. Let me know what you think.
…contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thank you for improving the experience, @bartektelec! 👏
Welcome to contributors! 🎉 |
Released: v1.2.4 🎉This has been released in v1.2.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Specifying the Error message:
|
specifies the pnpm version to use when contributing
enables contributors to easily switch to the correct version using
corepack
update:
looks like the codesandbox demo runs of
pnpm@7.26.3
, do we want to lock the pnpm version to the major?pnpm@^7.0.0