Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow installs with any version of pnpm #1713

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Aug 25, 2023

Listing engines.pnpm also affects consumers. The version of PNPM is only relevant for contributors so the correct lockfile gets generated. The consumers can use whichever PNPM, or other package manager's version they wish. I am not aware of the way to enforce certain engines for contributors only by package.json so I'm simply removing that restriction altogether.

@kettanaito kettanaito changed the title fix: remove "pnpm" from "engines" fix: allow installs with any version of pnpm Aug 25, 2023
@kettanaito kettanaito merged commit d35e851 into main Aug 25, 2023
10 checks passed
@kettanaito kettanaito deleted the fix/pnpm-engine branch August 25, 2023 09:56
@kettanaito
Copy link
Member Author

Released: v1.2.5 🎉

This has been released in v1.2.5!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install 1.2.4 version as it has pnpm specified to veriosn 7
1 participant