Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add product-x page #28106

Merged
merged 281 commits into from
Sep 13, 2021
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 2, 2021

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 8, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 8, 2021
docs/src/route.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 8, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2021
@mnajdova

This comment has been minimized.

@danilo-leal
Copy link
Contributor

[ ] 4. There is a horizontal scroll on smaller screens. Maybe we can make two rows for smaller screen sizes?
Screenshot 2021-09-05 at 13 47 16

Mm... Continuing with the six-block grid on small breakpoints would consume a lot of the screen's real state. But I see where the horizontal scroll on this current implementation is a problem: the difference between the X and the Home page.

home.page.mov
x.page.mov

If we made the horizontal sliders on the X page (and on others too) similar to the Home one, I believe it would compensate for the first hidden options as the currently selected block would move all of the scroll container. What do you think? @mnajdova

@mnajdova
Copy link
Member

mnajdova commented Sep 9, 2021

If we made the horizontal sliders on the X page (and on others too) similar to the Home one, I believe it would compensate for the first hidden options as the currently selected block would move all of the scroll container. What do you think?

Okay let’s do it

@mnajdova
Copy link
Member

One last comment from my side, I would maybe create a custom PNGs for dark mode to better match the background. This looks a bit off to me:

image

@siriwatknp
Copy link
Member Author

One last comment from my side, I would maybe create a custom PNGs for dark mode to better match the background. This looks a bit off to me:

@danilo-leal seems like it is worth to do 😂

@siriwatknp siriwatknp merged commit 1446bb4 into mui:next Sep 13, 2021
@siriwatknp
Copy link
Member Author

merged since all of the suggestion have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants