Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add product-x page #28106

Merged
merged 281 commits into from
Sep 13, 2021
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
281 commits
Select commit Hold shift + click to select a range
b4460d1
minor fixes
siriwatknp Aug 12, 2021
9fd022f
fix a11y
siriwatknp Aug 12, 2021
7cf0e13
fix a11y issues
siriwatknp Aug 12, 2021
6972016
add main section
siriwatknp Aug 12, 2021
600ada5
fix semantic and font
siriwatknp Aug 12, 2021
46f4dd0
add designkits branding prefetch
siriwatknp Aug 12, 2021
c04e34c
remove tabs to reduce motion
siriwatknp Aug 12, 2021
40a09ad
fix aria-label
siriwatknp Aug 12, 2021
3300fa3
fix wording
siriwatknp Aug 12, 2021
14fcff9
prevent focus on Hero components
siriwatknp Aug 12, 2021
164e61d
typo, missing space
oliviertassinari Aug 12, 2021
ac918e4
some overall design adjustments
danilo-leal Aug 12, 2021
66c3a67
success alert styling
danilo-leal Aug 12, 2021
94762bf
wording
danilo-leal Aug 12, 2021
0e1e703
Material-UI -> MUI
danilo-leal Aug 12, 2021
b8fbbe3
sponsors spacing tweak
danilo-leal Aug 12, 2021
e59073a
small adjustments
danilo-leal Aug 12, 2021
d79d749
more small tweaks and copywriting corrections
danilo-leal Aug 12, 2021
ab3006e
sponsors grid refinement
danilo-leal Aug 12, 2021
b0a6f90
minor fixes
siriwatknp Aug 13, 2021
5be2575
remove static images
siriwatknp Aug 13, 2021
b62e5c4
Merge branch 'rebranding/homepage2' of github.com:siriwatknp/material…
siriwatknp Aug 13, 2021
2934d70
fix margin and spacing
siriwatknp Aug 13, 2021
f12c03f
test new ux on the core showcase
siriwatknp Aug 13, 2021
12e85a5
fix layout
siriwatknp Aug 13, 2021
0669545
add transition
siriwatknp Aug 13, 2021
28f421c
support dark on core showcase
siriwatknp Aug 13, 2021
5bad676
run prettier and docs:formatted
siriwatknp Aug 13, 2021
37d79ab
move tooltip to local styling
siriwatknp Aug 13, 2021
2282a98
remove unused code
siriwatknp Aug 13, 2021
1a7f8fd
Update docs/src/components/home/Sponsors.tsx
siriwatknp Aug 14, 2021
052c524
Merge branch 'rebranding/homepage2' of github.com:siriwatknp/material…
siriwatknp Aug 14, 2021
86a871a
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Aug 14, 2021
33d604b
use xGrid in advanced showcase
siriwatknp Aug 14, 2021
68a3d65
skip tab in hero
siriwatknp Aug 14, 2021
cdf3dfb
minor adjustments
siriwatknp Aug 14, 2021
eed2696
fix types
siriwatknp Aug 14, 2021
3057944
fix switch thumb styles
siriwatknp Aug 14, 2021
38bc73c
add @media (prefers-reduced-motion)
oliviertassinari Aug 14, 2021
55d653c
capitalization convention
oliviertassinari Aug 14, 2021
11c27ee
use the full legal name
oliviertassinari Aug 14, 2021
92eef1b
We will have a third repository for the low-code effort
oliviertassinari Aug 14, 2021
6ab9e8c
add h3 section
oliviertassinari Aug 14, 2021
f06c93d
no jargon
oliviertassinari Aug 14, 2021
caf13be
English format
oliviertassinari Aug 14, 2021
07d0724
fix icons on ValueProposition
siriwatknp Aug 15, 2021
545009c
fix icons in WhatToExpect
siriwatknp Aug 15, 2021
d0174a6
fix icons on about
siriwatknp Aug 15, 2021
1458d93
fix icon color
siriwatknp Aug 15, 2021
1fad0fc
Merge branch 'rebranding/homepage2' of github.com:siriwatknp/material…
siriwatknp Aug 15, 2021
99ee152
add custom theme suggestion
siriwatknp Aug 15, 2021
7d160c5
design details
danilo-leal Aug 16, 2021
ff49213
tweaks on the hamburguer menu and other minor stuff
danilo-leal Aug 16, 2021
9e6a090
Merge branch 'next' into rebranding/homepage2
siriwatknp Aug 17, 2021
adccc60
fix colors
siriwatknp Aug 17, 2021
adca51b
cleanup outdated core showcase
siriwatknp Aug 17, 2021
d68fee9
run docs formatted
siriwatknp Aug 17, 2021
27a2fe7
fix stat number
siriwatknp Aug 17, 2021
fe448cc
add wip core page
siriwatknp Aug 17, 2021
1d40914
wip product advanced x
siriwatknp Aug 17, 2021
f82f5a8
add icons to XDataGrid
siriwatknp Aug 17, 2021
85235ab
add icons to XComponents
siriwatknp Aug 17, 2021
0688b9d
add icons to XRoadmap
siriwatknp Aug 17, 2021
c8e3a4a
wrap icons with RootSvg
siriwatknp Aug 17, 2021
d165bfc
add overline to CoreHero
siriwatknp Aug 17, 2021
f916a8d
fix missin id
siriwatknp Aug 17, 2021
f66c283
add empty id
siriwatknp Aug 17, 2021
d71141d
add wip templates page
siriwatknp Aug 17, 2021
32654e7
add wip design-kits page
siriwatknp Aug 17, 2021
cf4609f
add designkit components images
siriwatknp Aug 16, 2021
e558c5f
complete design-kits page
siriwatknp Aug 16, 2021
9abbed6
refactor Hero
siriwatknp Aug 16, 2021
4e00409
add template banners to product template page
siriwatknp Aug 16, 2021
468fdcf
fix shadow
siriwatknp Aug 16, 2021
909f186
complete product template page
siriwatknp Aug 16, 2021
55fe3ae
add link to store
siriwatknp Aug 16, 2021
ef399aa
add wip XHero
siriwatknp Aug 17, 2021
227caae
add FolderTreeView customization
siriwatknp Aug 18, 2021
f889689
add components to XHero
siriwatknp Aug 18, 2021
8baa7e9
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Aug 18, 2021
ad714b1
remove x-grid related
siriwatknp Aug 21, 2021
a2582e7
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Aug 21, 2021
bf07580
fix merge conflict
siriwatknp Aug 21, 2021
4d296e5
replace custom icons
siriwatknp Aug 21, 2021
8403de9
add default styling
siriwatknp Aug 21, 2021
f19c5e1
add demo to CoreComponents
siriwatknp Aug 21, 2021
ac59b60
add Demo to CoreTheming
siriwatknp Aug 21, 2021
ae3c127
add RealEstateCard to CoreStyling
siriwatknp Aug 21, 2021
de68918
add spacing
siriwatknp Aug 22, 2021
f203ec5
fix theming button bg
siriwatknp Aug 22, 2021
87ee17e
add material design components to hero
siriwatknp Aug 23, 2021
0382a1b
add scroll to highlight area
siriwatknp Aug 23, 2021
aa48c67
init refinement
siriwatknp Aug 23, 2021
3c9b982
colors refinement
danilo-leal Aug 23, 2021
f02c8f7
"not available" icon
danilo-leal Aug 23, 2021
c641e64
profile role text color
danilo-leal Aug 23, 2021
f87065d
pricing table adjustment
danilo-leal Aug 23, 2021
af6f042
early bird container tweaks
danilo-leal Aug 23, 2021
8ac1dc5
pricing table labels
danilo-leal Aug 23, 2021
b2d2b97
home page details
danilo-leal Aug 23, 2021
684f0fd
removing custom icons
danilo-leal Aug 23, 2021
bc81b97
minor stuff on the about page
danilo-leal Aug 23, 2021
a4b4240
standardize tooltip styles between pricing table and about
danilo-leal Aug 23, 2021
7bed031
about icon colors
danilo-leal Aug 23, 2021
b683b51
remove custom icons from about page
danilo-leal Aug 23, 2021
6f75e5a
minor details
danilo-leal Aug 23, 2021
df48355
link font weight
danilo-leal Aug 23, 2021
d9beee7
minor details
danilo-leal Aug 23, 2021
4cf5ac2
improve keyboard handling in nav
siriwatknp Aug 24, 2021
1fb1ee8
use primary.400 as main in darkmode
siriwatknp Aug 24, 2021
4d2dc2a
Merge branch 'rebranding/refinement' of github.com:siriwatknp/materia…
siriwatknp Aug 24, 2021
5c09616
make menu dropdown scrollable
siriwatknp Aug 24, 2021
f3e6033
add feature toggle for products menu
siriwatknp Aug 24, 2021
7800b21
add rich result structure to home
siriwatknp Aug 24, 2021
5b3fcf4
force html font-size
siriwatknp Aug 24, 2021
556f794
fix width
siriwatknp Aug 24, 2021
590db09
fix transparent issue
siriwatknp Aug 24, 2021
f470fb1
fix own styling toggle ui
siriwatknp Aug 24, 2021
beeb67d
run prettier
siriwatknp Aug 24, 2021
c972a97
fix pricing styling
siriwatknp Aug 24, 2021
95fea19
fix links
siriwatknp Aug 24, 2021
18ecde8
adjust chip
siriwatknp Aug 24, 2021
501d0ce
add tooltip to mode toggle
siriwatknp Aug 24, 2021
0920d6f
pass href to button
siriwatknp Aug 24, 2021
321af83
remove transition in sponsor
siriwatknp Aug 24, 2021
c5e3390
iterating with centering the icons
danilo-leal Aug 24, 2021
e7cc4f6
iterating with row hover bg
danilo-leal Aug 24, 2021
8e50365
iterating with the code flash margin
danilo-leal Aug 24, 2021
92b87bd
copywriting corrections
danilo-leal Aug 24, 2021
9209486
fix "buy now" link
danilo-leal Aug 24, 2021
732a66b
fix "buy now" link on mobile
danilo-leal Aug 24, 2021
e7aeed3
early bird icon spacing
danilo-leal Aug 24, 2021
bde4471
logo baseline alignment
danilo-leal Aug 24, 2021
686e55b
email subscription small tweak
danilo-leal Aug 24, 2021
a0d2a01
copywriting corrections
danilo-leal Aug 24, 2021
bf83374
add non breaking space on the hero copy
danilo-leal Aug 24, 2021
9d2a8e0
iteration on the sponsors section
danilo-leal Aug 24, 2021
2dcbfb4
small adjustments
danilo-leal Aug 24, 2021
c3e2a04
data grid accordion icon transition velocity
danilo-leal Aug 24, 2021
3e219de
data grid accordion row height
danilo-leal Aug 24, 2021
95aff16
iteration on the copywriting of value proposition and component demo …
danilo-leal Aug 24, 2021
4f9d194
Merge branch 'rebranding/refinement' of github.com:siriwatknp/materia…
siriwatknp Aug 25, 2021
25a90c8
increase logo size for diamond sponsor
siriwatknp Aug 25, 2021
0dfc6e4
fix pricing overflow
siriwatknp Aug 25, 2021
810d1fc
update pricing sticky head
siriwatknp Aug 25, 2021
92c600c
fix typo
siriwatknp Aug 25, 2021
bf1ff33
no bg for touch device
siriwatknp Aug 25, 2021
3898258
use the same ThemeContext between rebranding and docs
siriwatknp Aug 25, 2021
aaa26b7
update meta theme color
siriwatknp Aug 25, 2021
7cf21d8
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Aug 25, 2021
5fdcf4f
fix anchor underline
siriwatknp Aug 25, 2021
99c5271
cleanup deprecated ThemeProvider
siriwatknp Aug 25, 2021
011ea80
remove `passHref`
siriwatknp Aug 25, 2021
e5b21ce
run prettier
siriwatknp Aug 25, 2021
9d8aeec
change social preview
siriwatknp Aug 25, 2021
3b60598
fix lint
siriwatknp Aug 25, 2021
0a5bc26
remove minWidth
siriwatknp Aug 25, 2021
c3a81c6
adjust table of content color
siriwatknp Aug 25, 2021
a62661d
move CssBaseline to BrandingProvider
siriwatknp Aug 25, 2021
01f8cbb
Merge commit 'a62661ded4b9d12c4180f0d473be8d5d9861d824' into rebrandi…
siriwatknp Aug 25, 2021
54161ad
fix merge conflict
siriwatknp Aug 25, 2021
159a8ee
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Aug 30, 2021
974b8d9
minor adjustment
siriwatknp Aug 30, 2021
5eccdf3
remove last line
siriwatknp Aug 30, 2021
7c14c97
remove unused files
siriwatknp Aug 30, 2021
57c4697
set min-height
siriwatknp Aug 30, 2021
92d78be
revert code
siriwatknp Aug 30, 2021
d78f573
revert code
siriwatknp Aug 30, 2021
40c23ed
revert code
siriwatknp Aug 30, 2021
2812b8c
bring back some code (remove later)
siriwatknp Aug 30, 2021
15c0472
fix lint
siriwatknp Aug 30, 2021
46fb9ca
add x-grid package
siriwatknp Aug 30, 2021
91e698f
add advanced page
siriwatknp Aug 30, 2021
83ecdbb
add wip advanced demo
siriwatknp Aug 30, 2021
4e3366b
Merge branch 'next' into rebranding/x-advanced
siriwatknp Sep 2, 2021
ee5813f
rename imports
siriwatknp Sep 2, 2021
19671e7
fix dev error
siriwatknp Sep 2, 2021
c1c2fde
extract FlashCode component
siriwatknp Sep 2, 2021
798ffa3
wip XDataGrid
siriwatknp Sep 2, 2021
be04dba
wip
siriwatknp Sep 2, 2021
912d54c
update XDataGrid demo
siriwatknp Sep 2, 2021
9841a3c
prettier
siriwatknp Sep 2, 2021
0dcea5c
copywriting refinement
danilo-leal Sep 2, 2021
8b91624
reference company logos alignment and adjustments
danilo-leal Sep 2, 2021
beec2ef
adjustments to the XDataGrid section
danilo-leal Sep 2, 2021
189b0d1
sneaky fix on the core page
danilo-leal Sep 2, 2021
2079f16
border color fix
danilo-leal Sep 2, 2021
0a9b037
border fix again and other adjustments
danilo-leal Sep 2, 2021
e873e7c
data grid hero size
danilo-leal Sep 2, 2021
274fba6
one more available row and some icon tweaks
danilo-leal Sep 2, 2021
5d1e2f5
tree view styles tweaking
danilo-leal Sep 2, 2021
6c3e508
data grid hero row text color
danilo-leal Sep 2, 2021
17a3aeb
roadmap card responsive fix
danilo-leal Sep 2, 2021
b450cb0
fix mobile alignment
siriwatknp Sep 3, 2021
9ec7ed5
add XGrid full demo
siriwatknp Sep 3, 2021
237a15e
add XDateRangeDemo
siriwatknp Sep 3, 2021
489b7c0
prettier
siriwatknp Sep 3, 2021
11a327f
controls bg color data grid demo
danilo-leal Sep 3, 2021
64bbb9e
fix npm install
siriwatknp Sep 3, 2021
424890e
Merge branch 'rebranding/x-advanced' of https://github.com/siriwatknp…
danilo-leal Sep 3, 2021
5511cff
copywriting iteration
danilo-leal Sep 3, 2021
7c3fac7
iteration on the roadmap card
danilo-leal Sep 3, 2021
cc7330d
add "much more" btn to the components grid
danilo-leal Sep 3, 2021
faeacc0
"much more" btn route on the Data Grid section
danilo-leal Sep 3, 2021
78b4f8d
prettier
danilo-leal Sep 3, 2021
831f5b5
Merge branch 'next' of https://github.com/mui-org/material-ui into re…
siriwatknp Sep 6, 2021
9ea4c6b
fix Roadmap columns
siriwatknp Sep 6, 2021
3a3ed44
fix roadmap url
siriwatknp Sep 6, 2021
38ac0ff
fix typo name
siriwatknp Sep 6, 2021
6b1d10a
adjust grid styles
siriwatknp Sep 6, 2021
25c8900
fix as suggested
siriwatknp Sep 6, 2021
e49e21e
simplify sx value
siriwatknp Sep 6, 2021
40640fc
fix overflow
siriwatknp Sep 6, 2021
8bc9252
minor fixes
siriwatknp Sep 6, 2021
67d79f2
add TreeViewDemo
siriwatknp Sep 6, 2021
376c00d
add chart and sparkline
siriwatknp Sep 6, 2021
f0bab48
minor styling
siriwatknp Sep 6, 2021
03c1699
fix case sensitive
siriwatknp Sep 6, 2021
835780d
fix case sensitive
siriwatknp Sep 6, 2021
8222ceb
copywriting iteration
danilo-leal Sep 6, 2021
ce3bc83
tree view demo tweaks
danilo-leal Sep 6, 2021
c16d593
sparkline and chart demo preview adjustments
danilo-leal Sep 6, 2021
856403a
prettier
danilo-leal Sep 6, 2021
5f7a1f9
adjust images position
siriwatknp Sep 6, 2021
d281938
add pro info in pagination
siriwatknp Sep 6, 2021
1932db4
update DataGrid to @mui scope
siriwatknp Sep 6, 2021
ecb5ac3
fix types
siriwatknp Sep 6, 2021
c0db73f
copywriting tooltip iteration
danilo-leal Sep 6, 2021
340a5ff
Merge branch 'rebranding/x-advanced' of https://github.com/siriwatknp…
danilo-leal Sep 6, 2021
f319354
copywriting iteration
danilo-leal Sep 6, 2021
4958ae2
fix types
siriwatknp Sep 7, 2021
97c8105
add wip datagrid get started rotue
siriwatknp Sep 7, 2021
014cd5b
Merge branch 'rebranding/x-advanced' of github.com:siriwatknp/materia…
siriwatknp Sep 7, 2021
9e49613
remove old package
siriwatknp Sep 7, 2021
7fdc4c3
change to page `x`
siriwatknp Sep 7, 2021
ac93054
use env variable
siriwatknp Sep 7, 2021
cb8cc34
add data grid docs url
siriwatknp Sep 7, 2021
b02bf50
Merge branch 'next' into rebranding/x-advanced
siriwatknp Sep 8, 2021
a7e464f
Update docs/src/route.ts
siriwatknp Sep 8, 2021
cdb4813
minor copywriting fix
danilo-leal Sep 8, 2021
4473d7b
components demo styles tweaks
danilo-leal Sep 8, 2021
a54fe3d
prettier
danilo-leal Sep 8, 2021
dcb5e3e
Merge branch 'next' into rebranding/x-advanced
siriwatknp Sep 9, 2021
090787f
better quality pngs
danilo-leal Sep 9, 2021
e26afc4
fix date range size
siriwatknp Sep 10, 2021
c8365b1
scroll into view when click or focus
siriwatknp Sep 10, 2021
52f0933
fix grid styling
siriwatknp Sep 10, 2021
80acb8b
little copywriting fix
danilo-leal Sep 10, 2021
0bba77a
add sparkline & chart dark images
siriwatknp Sep 13, 2021
cf6d2b0
add prefetch images
siriwatknp Sep 13, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions docs/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,13 @@ module.exports = {
config.externals = [
(ctx, callback) => {
const { request } = ctx;
const hasDependencyOnRepoPackages = ['notistack', '@material-ui/data-grid'].includes(
request,
);
const hasDependencyOnRepoPackages = [
'notistack',
'@mui/x-data-grid',
'@mui/x-data-grid-pro',
'@mui/x-data-grid-generator',
'@material-ui/x-license',
].includes(request);

if (hasDependencyOnRepoPackages) {
return callback(null);
Expand Down Expand Up @@ -106,7 +110,8 @@ module.exports = {
// transpile 3rd party packages with dependencies in this repository
{
test: /\.(js|mjs|jsx)$/,
include: /node_modules(\/|\\)(notistack|@material-ui(\/|\\)data-grid)/,
include:
/node_modules(\/|\\)(notistack|@mui(\/|\\)x-data-grid|@mui(\/|\\)x-data-grid-pro|@mui(\/|\\)x-license-pro|@mui(\/|\\)x-data-grid-generator)/,
use: {
loader: 'babel-loader',
options: {
Expand Down
4 changes: 3 additions & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
"@fortawesome/fontawesome-svg-core": "^1.2.36",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"@fortawesome/react-fontawesome": "^0.1.15",
"@material-ui/data-grid": "^4.0.0-alpha.37",
"@mui/x-data-grid": "^4.0.0",
"@mui/x-data-grid-pro": "^4.0.0",
"@mui/x-data-grid-generator": "^4.0.0",
"@mui/core": "5.0.0-alpha.45",
"@mui/docs": "5.0.0-rc.0",
"@mui/icons-material": "5.0.0-rc.0",
Expand Down
8 changes: 8 additions & 0 deletions docs/pages/_app.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
/* eslint-disable import/first */
import { LicenseInfo } from '@mui/x-data-grid-pro';

// Remove the license warning from demonstration purposes
LicenseInfo.setLicenseKey(
'0f94d8b65161817ca5d7f7af8ac2f042T1JERVI6TVVJLVN0b3J5Ym9vayxFWFBJUlk9MTY1NDg1ODc1MzU1MCxLRVlWRVJTSU9OPTE=',
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked the x team about this, they confirm that this pattern is okay. However, @eps1lon suggest to take a look at how Remix tackle the license. I agree that it can be improved and will open an issue in the x repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could get the license key from an env var: https://docs.netlify.com/configure-builds/environment-variables/

Copy link
Member

@oliviertassinari oliviertassinari Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context:

  • Remix uses a private npm repository
  • We use the license key as a reminder for developers to know they are not licensed, it's not a hard constraint. The hard constraint is the international IP laws.

Regarding the advantages of a public repository, I can think of two:

Regarding the downsides:

  • We can't enforce that everybody is paying, it's going to be abused. In some way, it can be great, this developer abusing the license for a side project might be more likely to get his employer's pay, they likely wouldn't have paid.
  • We don't collect lead information, people a sales team could call back, to gather feedback on how well it went. Now, Kendo UI still has a public npm repository and asks for a free trial to go to a form to be licensed, we could always do the same.

👍 for exploring alternatives.

Copy link
Member

@oliviertassinari oliviertassinari Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify for me: We actually require leaking license keys to client bundle? How would we prove to a buyer that they shared the key illegally when it's just as likely that someone else just read the license key from their website?

@eps1lon In the current approach: we require leaking license keys to client bundles, correct. The license key is a reminder to purchase a license. For instance, it's not because a project has a valid license key that it's licensed.

Regarding the prior-arts, there were three influences:

More recently, I saw a new approach in https://www.telerik.com/kendo-react-ui/my-license/, we could also investigate it too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the prior-arts, there were three influences:

And why did you choose these approaches? Did you just choose them because somebody else is doing it? How can this possibly be a meassure of a "good" approach.

Also: I moved this discussion explicitly to internal channels since I realized how irresponsible it is to have this security related discussion in public.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach in https://www.telerik.com/kendo-react-ui/my-license/ is interesting:

  • @progress/kendo-licensing read the public key of the license during the build phase
  • once the license is read and validated with their public key, @progress/kendo-licensing updates the dist files at the data: ' {} ' placeholder.
  • once this is done, the library is built without containing the license key, it stays private on the server.

Regarding the cons:

  • Looking at the source, it might be a bit tricky to do correctly
  • It forces a build step, it's very common to have one, but not always

Copy link
Member

@oliviertassinari oliviertassinari Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the security aspect, the license key can be made public. I think that this thread is about, how can we find a more efficient approach, 1. in terms of doing less work on the runtime (bundle size, performance), and 2. in making it feel safer for the customers (some might feel that leaking their key in public is not great).

Ultimately, with patch-package, or even keeping the source on GitHub, I think that it's easy to cheat the current system, in #28106 (comment), I draw some of the arguments as to why it could be OK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened mui/mui-x#2565 for it.


import 'docs/src/modules/components/bootstrap';
// --- Post bootstrap -----
import * as React from 'react';
Expand Down
34 changes: 34 additions & 0 deletions docs/pages/branding/x-advanced.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import * as React from 'react';
import Head from 'docs/src/modules/components/Head';
import CssBaseline from '@mui/material/CssBaseline';
import BrandingProvider from 'docs/src/BrandingProvider';
import AppHeader from 'docs/src/layouts/AppHeader';
import XHero from 'docs/src/components/productX/XHero';
import XComponents from 'docs/src/components/productX/XComponents';
import XDataGrid from 'docs/src/components/productX/XDataGrid';
import XTheming from 'docs/src/components/productX/XTheming';
import XRoadmap from 'docs/src/components/productX/XRoadmap';
import References, { ADVANCED_CUSTOMERS } from 'docs/src/components/home/References';
import AppFooter from 'docs/src/layouts/AppFooter';

export default function Home() {
return (
<BrandingProvider>
<Head
title="MUI: Performant advanced components."
description="We are kicking it off with the most powerful Data Grid on the market and there's a lot more to come. Build complex applications with our advanced components."
/>
<CssBaseline />
<AppHeader />
<main>
<XHero />
<References companies={ADVANCED_CUSTOMERS} />
<XComponents />
<XDataGrid />
<XTheming />
<XRoadmap />
</main>
<AppFooter />
</BrandingProvider>
);
}
5 changes: 4 additions & 1 deletion docs/public/static/branding/companies/boeing-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion docs/public/static/branding/companies/boeing-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion docs/public/static/branding/companies/deloitte-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading