Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP_DEFER_ACCEPT socket option is not supported #271

Closed
candrews opened this issue Apr 28, 2022 · 0 comments
Closed

TCP_DEFER_ACCEPT socket option is not supported #271

candrews opened this issue Apr 28, 2022 · 0 comments
Assignees
@fw-strlen
Labels
enhancement

Comments

@candrews
Copy link

It appears that MPTCP in the kernel doesn't support the TCP_DEFER_ACCEPT socket option.

When starting apache 2 httpd with LD_PRELOAD=/usr/lib64/mptcpize/libmptcpwrap.so (which is provided by https://github.com/intel/mptcpd), this error is logged at startup:

[core:warn] [pid 2238878:tid 139880911450688] (95)Operation not supported: AH00076: Failed to enable APR_TCP_DEFER_ACCEPT

For http, the warning can be ignored as far as I can tell.

However, there are other applications that will fail if this socket option isn't supported, such as those based on Apache Thrift. For example, MapD fails with:

TServerSocket::listen() setsockopt() TCP_DEFER_ACCEPT Protocol not available
@candrews candrews mentioned this issue Apr 28, 2022
Closed
@fw-strlen fw-strlen self-assigned this May 1, 2022
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 2, 2022
@intel-lab-lkp
mptcp: sockopt: add TCP_DEFER_ACCEPT support
0ed8e00 
Support this via passthrough to the underlaying tcp listener socket.

Closes: multipath-tcp/mptcp_net-next#271
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 6, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
3476c1a 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
@matttbe matttbe closed this as completed in bce23a8 May 6, 2022
matttbe pushed a commit that referenced this issue May 6, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
0755e61 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 7, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
bd1bf40 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 9, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
bd223b5 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 9, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
218186c 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 10, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
b61aeb0 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 11, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
400c9b9 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 12, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
1b97691 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
jenkins-tessares pushed a commit that referenced this issue May 13, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
0beff4b 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 14, 2022
@intel-lab-lkp
mptcp: sockopt: add TCP_DEFER_ACCEPT support
c0197f5 
Support this via passthrough to the underlying tcp listener socket.

Closes: multipath-tcp/mptcp_net-next#271
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
jenkins-tessares pushed a commit that referenced this issue May 14, 2022
@jenkins-tessares
mptcp: sockopt: add TCP_DEFER_ACCEPT support
40194c4 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 14, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
74d2923 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 14, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
4db25c3 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 14, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
5f4efe5 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 14, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
d31d5d7 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 16, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
17c2c5e 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 16, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
3fc6c87 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 16, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
dfb5ed1 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 16, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
9b49f16 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe pushed a commit that referenced this issue May 16, 2022
@matttbe
mptcp: sockopt: add TCP_DEFER_ACCEPT support
e446664 
Support this via passthrough to the underlying tcp listener socket.

Closes: #271
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue May 16, 2022
@kuba-moo
mptcp: sockopt: add TCP_DEFER_ACCEPT support
ea1e301 
Support this via passthrough to the underlying tcp listener socket.

Closes: multipath-tcp/mptcp_net-next#271
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
jenkins-tessares pushed a commit that referenced this issue Oct 13, 2023
@borkmann
selftests/bpf: Test query on empty mprog and pass revision into attach
685446b 
Add a new test case to query on an empty bpf_mprog and pass the revision
directly into expected_revision for attachment to assert that this does
succeed.

  ./test_progs -t tc_opts
  [    1.406778] tsc: Refined TSC clocksource calibration: 3407.990 MHz
  [    1.408863] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x311fcaf6eb0, max_idle_ns: 440795321766 ns
  [    1.412419] clocksource: Switched to clocksource tsc
  [    1.428671] bpf_testmod: loading out-of-tree module taints kernel.
  [    1.430260] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
  #252     tc_opts_after:OK
  #253     tc_opts_append:OK
  #254     tc_opts_basic:OK
  #255     tc_opts_before:OK
  #256     tc_opts_chain_classic:OK
  #257     tc_opts_chain_mixed:OK
  #258     tc_opts_delete_empty:OK
  #259     tc_opts_demixed:OK
  #260     tc_opts_detach:OK
  #261     tc_opts_detach_after:OK
  #262     tc_opts_detach_before:OK
  #263     tc_opts_dev_cleanup:OK
  #264     tc_opts_invalid:OK
  #265     tc_opts_max:OK
  #266     tc_opts_mixed:OK
  #267     tc_opts_prepend:OK
  #268     tc_opts_query:OK
  #269     tc_opts_query_attach:OK     <--- (new test)
  #270     tc_opts_replace:OK
  #271     tc_opts_revision:OK
  Summary: 20/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20231006220655.1653-6-daniel@iogearbox.net
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
matttbe pushed a commit that referenced this issue Oct 27, 2023
@borkmann @anakryiko
selftests/bpf: Add additional mprog query test coverage
2451630 
Add several new test cases which assert corner cases on the mprog query
mechanism, for example, around passing in a too small or a larger array
than the current count.

  ./test_progs -t tc_opts
  #252     tc_opts_after:OK
  #253     tc_opts_append:OK
  #254     tc_opts_basic:OK
  #255     tc_opts_before:OK
  #256     tc_opts_chain_classic:OK
  #257     tc_opts_chain_mixed:OK
  #258     tc_opts_delete_empty:OK
  #259     tc_opts_demixed:OK
  #260     tc_opts_detach:OK
  #261     tc_opts_detach_after:OK
  #262     tc_opts_detach_before:OK
  #263     tc_opts_dev_cleanup:OK
  #264     tc_opts_invalid:OK
  #265     tc_opts_max:OK
  #266     tc_opts_mixed:OK
  #267     tc_opts_prepend:OK
  #268     tc_opts_query:OK
  #269     tc_opts_query_attach:OK
  #270     tc_opts_replace:OK
  #271     tc_opts_revision:OK
  Summary: 20/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Link: https://lore.kernel.org/bpf/20231017081728.24769-1-daniel@iogearbox.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fw-strlen fw-strlen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@candrews @matttbe @fw-strlen