Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled scroll follow in DialogueBox. #10

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

CantyCanadian
Copy link

The idea was sound. As the text appears, the box should be scrolling down. Unfortunately, scroll_following doesn't take into account [wait], so it scrolls immediately at the bottom and looks jarring. I disabled that option, and hope to find an alternative that's smarter. Here's a before-after.

before
after

Copy link
Owner

@nagidev nagidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will merge after pushing the newer changes.

@nagidev nagidev merged commit 32e0b66 into nagidev:main Oct 1, 2023
Deccir pushed a commit to Deccir/DialogueNodes that referenced this pull request Sep 19, 2024
…llow

Disabled scroll follow in DialogueBox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants