-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill deprecated Slimeballtag with entry again #1417
Conversation
Undoes accidental behavioral breaking change. Still, move to the other `c:slime_balls` tag instead
Last commit published: fd54cd758c625452c3f1ad00bb6262008d106048. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1417' // https://github.com/neoforged/NeoForge/pull/1417
url 'https://prmaven.neoforged.net/NeoForge/pr1417'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1417
cd NeoForge-pr1417
curl -L https://prmaven.neoforged.net/NeoForge/pr1417/net/neoforged/neoforge/21.0.154-pr-1417-SlimeBallTag/mdk-pr1417.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
I'm not sure how we should proceed with this. Ideally, the old tag would be included by the new tag. But should the new tag include the old one, or should the old one include the new one? |
New one include old tag. Old tag should not include new one to encourage people to switch to new tag. If old tag pulled from new tag, people won’t switch. Keeping old tag with slime ball means the mod will work as is with vanilla just fine. |
This PR currently doesn't include the old tag in the new one, it probably should then. |
@Matyrobbrt yes it does maty. The new tag already had the old tag included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah whoops, didn't notice.
Undoes accidental behavioral breaking change. Still, move to the other
c:slime_balls
tag instead