Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill deprecated Slimeballtag with entry again #1417

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Undoes accidental behavioral breaking change. Still, move to the other c:slime_balls tag instead

Undoes accidental behavioral breaking change. Still, move to the other `c:slime_balls` tag instead
@TelepathicGrunt TelepathicGrunt added regression Worked previously but doesn't anymore 1.21 Targeted at Minecraft 1.21 labels Aug 4, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 4, 2024

  • Publish PR to GitHub Packages

Last commit published: fd54cd758c625452c3f1ad00bb6262008d106048.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1417' // https://github.com/neoforged/NeoForge/pull/1417
        url 'https://prmaven.neoforged.net/NeoForge/pr1417'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1417.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1417
cd NeoForge-pr1417
curl -L https://prmaven.neoforged.net/NeoForge/pr1417/net/neoforged/neoforge/21.0.154-pr-1417-SlimeBallTag/mdk-pr1417.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt
Copy link
Member

I'm not sure how we should proceed with this. Ideally, the old tag would be included by the new tag. But should the new tag include the old one, or should the old one include the new one?

@TelepathicGrunt
Copy link
Contributor Author

New one include old tag. Old tag should not include new one to encourage people to switch to new tag. If old tag pulled from new tag, people won’t switch. Keeping old tag with slime ball means the mod will work as is with vanilla just fine.

@Matyrobbrt
Copy link
Member

This PR currently doesn't include the old tag in the new one, it probably should then.

@TelepathicGrunt
Copy link
Contributor Author

@Matyrobbrt yes it does maty. The new tag already had the old tag included.
IMG_1059

Copy link
Member

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops, didn't notice.

@TelepathicGrunt TelepathicGrunt merged commit 3702a4d into neoforged:1.21.x Aug 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 regression Worked previously but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants