Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence logging for deprecated slimeball tag #1424

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Error made in:
#1417

We already logged when c:slimeballs is present. With that PR above, we re-added that tag which then triggers the logging for NeoForge alone

@TelepathicGrunt TelepathicGrunt added bug A bug or error 1.21 Targeted at Minecraft 1.21 labels Aug 5, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 5, 2024

  • Publish PR to GitHub Packages

Last commit published: ab00eeebecaea05bd211f6c8c32fd09779007d71.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1424' // https://github.com/neoforged/NeoForge/pull/1424
        url 'https://prmaven.neoforged.net/NeoForge/pr1424'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1424.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1424
cd NeoForge-pr1424
curl -L https://prmaven.neoforged.net/NeoForge/pr1424/net/neoforged/neoforge/21.0.166-pr-1424-SlimeballTagWarning/mdk-pr1424.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt Matyrobbrt merged commit 82832d0 into neoforged:1.21.x Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants