Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1882 make sure pkt drop hook is disabled for PCA feature #413

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Sep 17, 2024

Description

PCA feature was failing to load ebpf prog with this error
loading and assigning BPF objects: field KfreeSkb: program kfree_skb: load program: permission denied: combined stack size of 2 calls is 544. Too large (1 line(s) omitted)"

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 17, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:0f6b737

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=0f6b737 make set-agent-image

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6ac7c5c). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ebpf/tracer.go 0.00% 42 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage        ?   30.18%           
=======================================
  Files           ?       49           
  Lines           ?     4071           
  Branches        ?        0           
=======================================
  Hits            ?     1229           
  Misses          ?     2737           
  Partials        ?      105           
Flag Coverage Δ
unittests 30.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)

@jpinsonneau jpinsonneau changed the title make sure pkt drop hook is disabled for PCA feature NETOBSERV-1882 make sure pkt drop hook is disabled for PCA feature Sep 17, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 17, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 17, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:38b9835

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=38b9835 make set-agent-image

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 17, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 17, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:b81efd8

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=b81efd8 make set-agent-image

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @msherif1234 !

@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234
Copy link
Contributor Author

konflux reached limit You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@msherif1234 msherif1234 merged commit 27cbe69 into netobserv:main Sep 17, 2024
9 of 11 checks passed
@jpinsonneau jpinsonneau added the no-qe This PR doesn't necessitate QE approval label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants