-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1882 test e2e faillure #90
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 26.16% 25.10% -1.06%
==========================================
Files 8 8
Lines 1093 1147 +54
==========================================
+ Hits 286 288 +2
- Misses 786 838 +52
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
596f245
to
7bcfe40
Compare
7bcfe40
to
dc16283
Compare
dc16283
to
bc7e336
Compare
da0c7cd
to
4786268
Compare
37daf55
to
a081ece
Compare
8a64877
to
669db82
Compare
669db82
to
6ad84b0
Compare
res/packet-capture.yml
Outdated
- name: ENABLE_NETWORK_EVENTS_MONITORING | ||
value: "false" | ||
- name: ENABLE_FLOW_FILTER | ||
value: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need those changes since those features are irrelevant to pca ? just wanted to avoid any confusion if someone mistakenly enabled them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure let's get rid of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Dependencies
netobserv/netobserv-ebpf-agent#413
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.