Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1882 test e2e faillure #90

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Sep 16, 2024

Description

  • added eBPF agents logs
  • added collector trace logs
  • updated kind version
  • display kernel version

Dependencies

netobserv/netobserv-ebpf-agent#413

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 54 lines in your changes missing coverage. Please review.

Project coverage is 25.10%. Comparing base (248df00) to head (06068df).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
cmd/packet_capture.go 0.00% 17 Missing ⚠️
cmd/flow_capture.go 11.11% 16 Missing ⚠️
e2e/cluster/kind.go 0.00% 12 Missing ⚠️
cmd/root.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   26.16%   25.10%   -1.06%     
==========================================
  Files           8        8              
  Lines        1093     1147      +54     
==========================================
+ Hits          286      288       +2     
- Misses        786      838      +52     
  Partials       21       21              
Flag Coverage Δ
unittests 25.10% <3.57%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
e2e/common.go 0.00% <ø> (ø)
cmd/root.go 47.61% <0.00%> (-12.99%) ⬇️
e2e/cluster/kind.go 0.00% <0.00%> (ø)
cmd/flow_capture.go 31.73% <11.11%> (-1.08%) ⬇️
cmd/packet_capture.go 0.00% <0.00%> (ø)

@jpinsonneau jpinsonneau force-pushed the test_e2e_failure branch 2 times, most recently from 596f245 to 7bcfe40 Compare September 16, 2024 13:56
@jpinsonneau jpinsonneau changed the title test go mod update test e2e faillure Sep 16, 2024
@jpinsonneau jpinsonneau changed the title test e2e faillure NETOBSERV-1882 test e2e faillure Sep 17, 2024
@jpinsonneau jpinsonneau force-pushed the test_e2e_failure branch 2 times, most recently from 8a64877 to 669db82 Compare September 17, 2024 12:39
- name: ENABLE_NETWORK_EVENTS_MONITORING
value: "false"
- name: ENABLE_FLOW_FILTER
value: "false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need those changes since those features are irrelevant to pca ? just wanted to avoid any confusion if someone mistakenly enabled them ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure let's get rid of these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msherif1234
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau merged commit dd4a15c into netobserv:main Sep 17, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants