fix: Updated redis instrumentation to parse host/port when a url is not provided #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
previously approved these changes
Aug 13, 2024
Comment on lines
+33
to
+34
| port: params.redis_port, | ||
| host: params.redis_host |
There was a problem hiding this comment.
For future readers: the alternate form is tested in another suite:
node-newrelic/test/versioned/redis/redis-v4.tap.js
Lines 30 to 31 in b4b6a6b
jsumners-nr
approved these changes
Aug 14, 2024
Merged
This was referenced Sep 10, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ot provided
Description
This PR addresses handling parsing host/port when provided to connect when assigning host and port on the spans for redis
How to Test
Related Issues
Closes #2462