Implement highlighting of active feed item and more keyboard shortcuts #2677
Conversation
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
|
Needed a little trickery... |
pbek
changed the title
|
Meanwhile, I added a few more keyboard shortcuts |
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
|
Cool, code looks ok to me. I will try it when I have time to make sure :) |
At least the "trying" is one git checkout and |
|
I spent so many hours in bringing the current item into view in the |
|
Just tested this, works nice. But yea it seems like VirtualScroll is not the solution for news. It has this other issue being very jumpy when scrolling. If you feel done with this (at the moment) we can merge this |
|
Ah two commits miss the sign-off https://github.com/nextcloud/news/pull/2677/checks?check_run_id=25958808201 |
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
Sorry, I fixed that now.
Thank you!
Have you seen anything in another app that is more to your liking?
Yes, I'm done with that PR. Thank you! |
No, I'm not a big user of the nextcloud or even news in the web. I mostly use the android apps. related: #2498 |
Interesting... Which Android App do you use? I use (Nextcloud) News on Android. But I read mostly on the web directly.
Hm, then maybe just a container with infinite scroll? |
|
Changed - added alternative development environment (#2670) - Implement `j` and `k` keyboards shortcuts for navigating through feed items (#2671) - Implement `s`, `i` and `l` keyboards shortcuts for staring current feed item (#2677) - Implement `o` keyboards shortcut for opening the URL of current feed item (#2677) - Implement `u` keyboards shortcut for marking current feed item read/unread (#2677) - Implement highlighting of active feed item (#2677) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Changed - added alternative development environment (#2670) - Implement `j` and `k` keyboards shortcuts for navigating through feed items (#2671) - Implement `s`, `i` and `l` keyboards shortcuts for staring current feed item (#2677) - Implement `o` keyboards shortcut for opening the URL of current feed item (#2677) - Implement `u` keyboards shortcut for marking current feed item read/unread (#2677) - Implement highlighting of active feed item (#2677) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
To help with #2671.
Summary
jandkkeyboards shortcuts for navigating through feed itemss,iandlkeyboards shortcuts for staring current feed itemokeyboards shortcut for opening the URL of current feed itemukeyboards shortcut for marking current feed item read/unread