fix: scrolling when using keyboard navigation #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
fix-scrolling-with-key-navigation
branch
from
228d669
to
c48ffd0
Compare
Grotax
force-pushed
the
fix-scrolling-with-key-navigation
branch
from
00a1f8d
to
5a1a3e6
Compare
feed-item-row height is actual 110.66px, but setting this fixed is not optimal and should be changed in the future. Signed-off-by: Wolfgang <github@linux-dude.de>
Grotax
force-pushed
the
fix-scrolling-with-key-navigation
branch
from
5a1a3e6
to
862e44c
Compare
Grotax
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feed-item-row height is actual 110.66px, but setting this fixed is not optimal and should be changed in the future.
related: #2498 #2677
Summary
The scrolling was prepared in #2677, but not active. This activate scrolling and fixed the bumping.
Checklist