Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaccine cross date #498

Merged
merged 8 commits into from
Feb 14, 2018
Merged

Vaccine cross date #498

merged 8 commits into from
Feb 14, 2018

Conversation

jameshadfield
Copy link
Member

Additions

  • When the tree is temporal, there are dotted lines from the tip to the vaccine date. For non-temporal trees as well as clock layout the cross is in the same position as the tip.
  • Vaccine crosses have the same onClick, onHover, onMouseOver callbacks as the corresponding tip.

Code improvements

  • mapToScreen has been sped up by about a third.
  • updateGeometryFade now uses a transition counter to fire different steps when the preceding step is finished rather than using setTimeout and guessing how long each step will take.

Regressions

  • Vaccine cross styling no longer has a white outline. This is because it has to be drawn as a SVG shape rather than text to have onClick events etc. Could be fixed if the SVG shape was a X rather than a path of two lines.

Screenshots

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant