Adjust branch label and vaccine cross styling #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add weight and lighten clade labels, shrink mutation labels
Remove the extra dashed branch.
|
@trvrb the reason they are SVG shapes not crosses with the nice styling is to do with attaching handlers to them - see #498. If they are always going to be directly over the tip then I guess it's not necessary. However I think there is some work in the future on this where we could show info regarding deployment time etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jameshadfield ---
The changes to branch label styling shouldn't be controversial. However, I've decided to remove the dashed lines from the vaccine crosses. I believe it was adding confusion rather than removing it. If we go in this direction I think we need the full description of choice and deployment. But even then I really feel like it will be overloading the tree. Perhaps the best thing to think toward is a separate vaccine panel.
Also, I think the symbols (vaccine crosses, serum gears) look much better with a bit of white space surrounding them. This was accomplished previously by using a character as the cross and giving a stroke of
#fffand a fill of#333. Something to think about.