Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote-service] Add a path to save the model @open sesame 11/17 16:24 #411

Merged
merged 2 commits into from
Nov 27, 2023
Merged

[Remote-service] Add a path to save the model @open sesame 11/17 16:24 #411

merged 2 commits into from
Nov 27, 2023

Conversation

gichan-jang
Copy link
Member

Add a path to save the received model file to the ml-option.

Signed-off-by: gichan2-jang gichan2.jang@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 20, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #411. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@gichan-jang gichan-jang changed the title [Remote-service] Add a path to save the model After #408 [Remote-service] Add a path to save the model Oct 20, 2023
@gichan-jang gichan-jang force-pushed the remote/set/path branch 2 times, most recently from 1700e66 to 6953cae Compare October 20, 2023 08:10
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 20, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/411-202310201710520.0076560974121094-6953cae7b1c57e24b14f2b7c504cecdf7dd3ff3a/.

@gichan-jang gichan-jang changed the title After #408 [Remote-service] Add a path to save the model [Remote-service] Add a path to save the model Nov 17, 2023
taos-ci
taos-ci approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 17, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/411-202311171514230.48233008384705-5163b450bdee02044304d24c586e7c24509b4a38/.

@gichan-jang gichan-jang changed the title [Remote-service] Add a path to save the model [Remote-service] Add a path to save the model @open sesame 11/17 16:24 Nov 17, 2023
taos-ci
taos-ci approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✔

songgot
songgot approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gichan-jang
[Remote-service] Add a path to save the model
fee4298 
Add a path to save the received model file to the ml-option.

Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
@gichan-jang
[TEST] Code clean: Use G_DIR_SEPARATOR_S
9c27fe0 
Let's use G_DIR_SEPARATOR_S instead of "/".

Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
taos-ci
taos-ci approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit afd687a into nnstreamer:main Nov 27, 2023
29 checks passed
@songgot songgot mentioned this pull request Dec 1, 2023
Merged
@gichan-jang gichan-jang deleted the remote/set/path branch February 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@songgot songgot songgot approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
PR/Ready2Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gichan-jang @taos-ci @anyj0527 @songgot @jaeyun-jung