[Example] ml service API name is changed #319
Conversation
songgot
requested review from
jaeyun-jung,
myungjoo,
again4you,
leemgs,
wooksong,
gichan-jang and
anyj0527
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #319. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot:
|
|
| sdb push mosquitto-1.6.8-0.armv7l.rpm mosquitto-clients-1.6.8-0.armv7l.rpm | ||
|
|
||
| [taget] | ||
| mount -o remount rw, / |
There was a problem hiding this comment.
I think this line is an overly kind guide.
There was a problem hiding this comment.
Okay, I will remove this line. Thank you.
| sdb push mosquitto-1.6.8-0.armv7l.rpm mosquitto-clients-1.6.8-0.armv7l.rpm | ||
|
|
||
| [taget] | ||
| rpm -Uvh --force --nodeps *.rpm |
There was a problem hiding this comment.
- Unnecessary (and dangerous) options? --force, --nodeps
- Add a note about the arch (armv7l vs aarch64). We have images of both architectures for RPI4.
- taget --> target
| // if (ML_ERROR_NONE != ret) { | ||
| // dlog_print (DLOG_ERROR, LOG_TAG, "Failed to set path (%d)", ret); | ||
| // return; | ||
| // } |
There was a problem hiding this comment.
Why commented this?
(it usually confuse other developers, especially if this is a sample app)
There was a problem hiding this comment.
Thank you.
I tried modifying rootstrap, but it didn't test well. so, this has not yet been verified.
I will conduct testing after the related PR( (nnstreamer/api#411) is merged into Tizen.
There was a problem hiding this comment.
#if 0 and commenting out code have the same effect on code readers (confuse sample app readers).
If you really want to add such deactivated code upstreamed, add an explanation (in the code) why it is commented out and the condition when the code will be reactivated.
There was a problem hiding this comment.
Thank you. I will add a comment.
songgot
force-pushed
the
rename_api
branch
2 times, most recently
from
6e8b6af
to
240cf74
Compare
- Add setting and start MQTT to md - API name is changed from ml_remote_service_* to ml_service_remote_* - bugfix: remove double free, unnecessary free function registered in function ml_option_set Signed-off-by: hyunil park <hyunil46.park@samsung.com>
Self evaluation: