Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: internalBinding TypeError when running benchmark #23436

Closed
ZYSzys opened this issue Oct 12, 2018 · 1 comment
Closed

benchmark: internalBinding TypeError when running benchmark #23436

ZYSzys opened this issue Oct 12, 2018 · 1 comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.

Comments

@ZYSzys
Copy link
Member

ZYSzys commented Oct 12, 2018

  • Version:master branch
  • Platform:Darwin

When I run benchmark as the document said, It came out TypeError: internalBinding is not a function as below:
screen shot 2018-10-12 at 9 05 46 am

Is this a bug, or the document is incomplete ?
@richardlau
Copy link
Member

cc @jasnell This was changed via #22329

@cjihrig cjihrig mentioned this issue Oct 12, 2018
Merged
3 tasks
@ChALkeR ChALkeR added benchmark Issues and PRs related to the benchmark subsystem. macos Issues and PRs related to the macOS platform / OSX. and removed macos Issues and PRs related to the macOS platform / OSX. labels Oct 12, 2018
cjihrig added a commit to cjihrig/node that referenced this issue Oct 14, 2018
@cjihrig
benchmark: add common.binding()
ff8db70 
Recently, process.binding() was replaced with internalBinding().
However, internalBinding() is not available on older builds of
Node, which are often used for benchmarking purposes. This commit
adds a common.binding() to the benchmarks to work around the
issue. Hopefully, this can be removed in the not too distant
future.

PR-URL: nodejs#23460
Fixes: nodejs#23436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this issue Oct 17, 2018
@cjihrig @jasnell
benchmark: add common.binding()
2ca7aeb 
Recently, process.binding() was replaced with internalBinding().
However, internalBinding() is not available on older builds of
Node, which are often used for benchmarking purposes. This commit
adds a common.binding() to the benchmarks to work around the
issue. Hopefully, this can be removed in the not too distant
future.

PR-URL: #23460
Fixes: #23436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChALkeR @richardlau @ZYSzys