benchmark: add common.binding() #23460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
targos
approved these changes
Oct 12, 2018
jasnell
added
code-and-learn
jasnell
approved these changes
Oct 12, 2018
targos
removed
the
code-and-learn
starkwang
approved these changes
Oct 13, 2018
trivikr
approved these changes
Oct 13, 2018
Recently, process.binding() was replaced with internalBinding(). However, internalBinding() is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds a common.binding() to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future. PR-URL: nodejs#23460 Fixes: nodejs#23436 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig
force-pushed
the
benchmark-bindings
branch
from
547554e
to
ff8db70
Compare
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Recently, process.binding() was replaced with internalBinding(). However, internalBinding() is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds a common.binding() to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future. PR-URL: #23460 Fixes: #23436 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
This relies on a semver-major commit. Thus it should not be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently,
process.binding()was replaced withinternalBinding(). However,internalBinding()is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds acommon.binding()to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future.Fixes: #23436
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes