Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node --inspect-brk --debug prints incorrect error message #28588

Closed
fasttime opened this issue Jul 7, 2019 · 0 comments · Fixed by #28589
Closed

node --inspect-brk --debug prints incorrect error message #28588

fasttime opened this issue Jul 7, 2019 · 0 comments · Fixed by #28589

Comments

@fasttime
Copy link
Contributor

fasttime commented Jul 7, 2019

  • Version: 12.6.0
  • Platform: Darwin 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
$ node --inspect-brk --debug
node: [DEP0062]: `node --inspect --debug-brk` is deprecated. Please use `node --inspect-brk` instead.

Two issues here. The error message suggests that node was called with options --inspect and --debug-brk which is not the case. And it recommends using --inspect-brk instead, one of the options actually used.
@cjihrig cjihrig mentioned this issue Jul 7, 2019
Merged
3 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Jul 9, 2019
@cjihrig
src: simplify DEP0062 logic
b851469 
This commit simplifies the DEP0062 error logic. Instead of
looking for certain combinations of flags, just show an error
for any usage of --debug or --debug-brk.

PR-URL: nodejs#28589
Fixes: nodejs#28588
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Jul 20, 2019
@cjihrig @targos
src: simplify DEP0062 logic
c432ab1 
This commit simplifies the DEP0062 error logic. Instead of
looking for certain combinations of flags, just show an error
for any usage of --debug or --debug-brk.

PR-URL: #28589
Fixes: #28588
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: simplify DEP0062 logic cjihrig/node
1 participant
@fasttime