src: simplify DEP0062 logic #28589
Merged
src: simplify DEP0062 logic #28589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
BridgeAR
approved these changes
Jul 7, 2019
fhinkel
approved these changes
Jul 8, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/24329/ EDIT(cjihrig): CI was yellow. |
cjihrig
added
the
author ready
Trott
approved these changes
Jul 8, 2019
This commit simplifies the DEP0062 error logic. Instead of looking for certain combinations of flags, just show an error for any usage of --debug or --debug-brk. PR-URL: nodejs#28589 Fixes: nodejs#28588 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit simplifies the DEP0062 error logic. Instead of looking for certain combinations of flags, just show an error for any usage of --debug or --debug-brk. PR-URL: #28589 Fixes: #28588 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the
DEP0062error logic. Instead of looking for certain combinations of flags, just show an error for any usage of--debugor--debug-brk.Fixes: #28588
It's also worth noting that
DEP0062was moved to End-of-Life, meaning that all of this logic can be removed. However, it might be worth leaving it around to print the deprecation message since--debugis a much more logical name than--inspect.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes