Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test test-http2-pipe-named-pipe on osx-arm #40277

Closed
targos opened this issue Oct 1, 2021 · 5 comments
Closed

Investigate flaky test test-http2-pipe-named-pipe on osx-arm #40277

targos opened this issue Oct 1, 2021 · 5 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. macos Issues and PRs related to the macOS platform / OSX.

Comments

@targos
Copy link
Member

targos commented Oct 1, 2021

It's been happening regularly for some time.

  • Test: test-http2-pipe-named-pipe
  • Platform: macOS arm64
  • Console Output:
node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

139837 !== 139244

    at WriteStream.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/parallel/test-http2-pipe-named-pipe.js:26:12)
    at WriteStream.emit (node:events:402:35)
    at finish (node:internal/streams/writable:751:10)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 139837,
  expected: 139244,
  operator: 'strictEqual'
}

Node.js v17.0.0-pre
@targos targos added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. http2 Issues or PRs related to the http2 subsystem. labels Oct 1, 2021
@mhdawson
Copy link
Member

@targos
Copy link
Member Author

targos commented Nov 3, 2021

I tried to investigate on my mac (the test fails 30-50% of the runs), but I haven't found anything interesting. I suspect it's a bug in Node.js (not in the test), but I may be wrong.

@Trott
Copy link
Member

Trott commented Nov 3, 2021

I tried to investigate on my mac (the test fails 30-50% of the runs), but I haven't found anything interesting. I suspect it's a bug in Node.js (not in the test), but I may be wrong.

This may be asking a lot but if you go to the commit where the test was first added, is it flaky there? If not, perhaps a (no doubt time-consuming) bisect might find something interesting?

@targos
Copy link
Member Author

targos commented Nov 3, 2021

I tried to investigate on my mac (the test fails 30-50% of the runs), but I haven't found anything interesting. I suspect it's a bug in Node.js (not in the test), but I may be wrong.

This may be asking a lot but if you go to the commit where the test was first added, is it flaky there? If not, perhaps a (no doubt time-consuming) bisect might find something interesting?

I'm afraid that's not possible because the test was added in 2018 and M1 mac support was added last year. IIRC, I've always seen it fail since I bought the laptop in January.

lpinca added a commit to lpinca/node that referenced this issue Nov 17, 2021
Wait for all data to be read before sending the response and closing
the client.

Fixes: nodejs#40277
lpinca added a commit to lpinca/node that referenced this issue Nov 17, 2021
Wait for all data to be read before sending the response and closing
the client.

Fixes: nodejs#40277
nodejs-github-bot pushed a commit that referenced this issue Nov 21, 2021
Wait for all data to be read before sending the response and closing
the client.

Fixes: #40277

PR-URL: #40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
nodejs-github-bot pushed a commit that referenced this issue Nov 21, 2021
The first argument is the actual value, the second argument is the
expected value.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this issue Nov 21, 2021
`http2-url-tests.js` is misleading. Use the same name of the source file
instead.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this issue Nov 21, 2021
Wait for all data to be read before sending the response and closing
the client.

Fixes: #40277

PR-URL: #40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this issue Nov 21, 2021
The first argument is the actual value, the second argument is the
expected value.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
`http2-url-tests.js` is misleading. Use the same name of the source file
instead.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
Wait for all data to be read before sending the response and closing
the client.

Fixes: #40277

PR-URL: #40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
The first argument is the actual value, the second argument is the
expected value.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
`http2-url-tests.js` is misleading. Use the same name of the source file
instead.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
Wait for all data to be read before sending the response and closing
the client.

Fixes: #40277

PR-URL: #40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
The first argument is the actual value, the second argument is the
expected value.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants