lib: fix version check in tick processor #16769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Nov 5, 2017
jasnell
approved these changes
Nov 6, 2017
Introduced in 70832bc ("build: add V8 embedder version string".) Fixes: nodejs#16736 PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Make it possible to test the versionCheck() function from that file in isolation. PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Verify that v8-version log lines are parsed and matched correctly. Fixes: nodejs#16736 PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Introduced in 70832bc ("build: add V8 embedder version string".) Fixes: nodejs#16736 PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Make it possible to test the versionCheck() function from that file in isolation. PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Verify that v8-version log lines are parsed and matched correctly. Fixes: nodejs#16736 PR-URL: nodejs#16769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
Should this be backported to |
|
Since this fixes a bug introduced in #15785 and that PR is marked semver-major, I'm guessing no. I'll update the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16736
CI: https://ci.nodejs.org/job/node-test-pull-request/11198/