Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix version check in tick processor #16769

Merged
merged 3 commits into from
Nov 7, 2017
Merged

lib: fix version check in tick processor #16769

merged 3 commits into from
Nov 7, 2017

Commits on Nov 7, 2017

  1. lib: fix version check in tick processor 

    Introduced in 70832bc ("build: add V8 embedder version string".)

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    421316d View commit details
    Browse the repository at this point in the history

  2. lib: shuffle v8_prof_polyfill.js for unit testing 

    Make it possible to test the versionCheck() function from that file in
isolation.

PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    09d22dd View commit details
    Browse the repository at this point in the history

  3. test: tick processor version check regression test 

    Verify that v8-version log lines are parsed and matched correctly.

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    698bb96 View commit details
    Browse the repository at this point in the history