test: do not use valid public hosts for timeout testing #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
net
I think they are tests that can rely on one. If it doesn't rely on one anymore, I figure it could be moved to parallel. |
| gotConnect1 = true; | ||
| socket1.destroy(); | ||
| gotConnect = true; | ||
| socket.destroy(); | ||
| }); |
There was a problem hiding this comment.
You could replace the callback with just assert.fail.
|
LGTM |
Trott
added a commit
that referenced
this pull request
Jul 28, 2015
PR-URL: #2057 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
landed in c786d63 |
|
Shouldn't this test be moved to |
|
@Fishrock123 see #2257 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of assumptions I've made:
test/internetdirectory: Is it just tests that rely on an internet connection but really shouldn't ideally? Or is that an incorrect assumption? (Is it documented anywhere?) Now that this one doesn't rely on a working internet connection, should it be moved totest/parallelinstead?Additional information that may be useful:
240.0.0.0might, theoretically, be used at some future time. But that is unlikely. And even so, it's still a better choice for the foreseeable future than a valid Time-Warner IP, which is what it seems the previous one was.