Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not use valid public hosts for timeout testing #2057

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 13 additions & 42 deletions test/internet/test-net-connect-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,70 +2,41 @@
// This example attempts to time out before the connection is established
// https://groups.google.com/forum/#!topic/nodejs/UE0ZbfLt6t8
// https://groups.google.com/forum/#!topic/nodejs-dev/jR7-5UDqXkw
//
// TODO: how to do this without relying on the responses of specific sites?

var common = require('../common');
var net = require('net');
var assert = require('assert');

var start = new Date();

var gotTimeout0 = false;
var gotTimeout1 = false;
var gotTimeout = false;

var gotConnect0 = false;
var gotConnect1 = false;
var gotConnect = false;

var T = 100;


// With DNS
// 240.*.*.*.* is "reserved for future use"
var socket = net.createConnection(9999, '240.0.0.0');

var socket0 = net.createConnection(9999, 'google.com');
socket.setTimeout(T);

socket0.setTimeout(T);

socket0.on('timeout', function() {
console.error('timeout');
gotTimeout0 = true;
var now = new Date();
assert.ok(now - start < T + 500);
socket0.destroy();
});

socket0.on('connect', function() {
console.error('connect');
gotConnect0 = true;
socket0.destroy();
});


// Without DNS

var socket1 = net.createConnection(9999, '24.24.24.24');

socket1.setTimeout(T);

socket1.on('timeout', function() {
socket.on('timeout', function() {
console.error('timeout');
gotTimeout1 = true;
gotTimeout = true;
var now = new Date();
assert.ok(now - start < T + 500);
socket1.destroy();
socket.destroy();
});

socket1.on('connect', function() {
socket.on('connect', function() {
console.error('connect');
gotConnect1 = true;
socket1.destroy();
gotConnect = true;
socket.destroy();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could replace the callback with just assert.fail.



process.on('exit', function() {
assert.ok(gotTimeout0);
assert.ok(!gotConnect0);

assert.ok(gotTimeout1);
assert.ok(!gotConnect1);
assert.ok(gotTimeout);
assert.ok(!gotConnect);
});