Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution process based on #219. #224

Merged
merged 2 commits into from
Oct 9, 2015
Merged

Contribution process based on #219. #224

merged 2 commits into from
Oct 9, 2015

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Oct 8, 2015

This is a modification of the process we use for core giving certain rights to the admin group.

opinions of other Collaborators and guidance of the Website Admin Group.

Collaborators may **close** any issue or pull request they believe is
not relevant for the future of the Node.js project. Where this is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nodejs.org?

@mikeal mikeal mentioned this pull request Oct 8, 2015
@fhemberger
Copy link
Contributor

SGTM.


All pull requests that modify executable code should be subjected to
continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't CI on travis instead of jenkins here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a jenkins thing that publishes the content in master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that makes sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a jenkins thing that publishes the content in master.

What is the website related stuff called?

mikeal added a commit that referenced this pull request Oct 9, 2015
Contribution process based on #219.
@mikeal mikeal merged commit 6fd2132 into master Oct 9, 2015
@phillipj phillipj deleted the contributing branch November 19, 2015 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants