-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution process based on #219. #224
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,87 @@ | ||
# Node.js Collaborator Guide | ||
|
||
**Contents** | ||
|
||
* [Issues and Pull Requests](#issues-and-pull-requests) | ||
* [Accepting Modifications](#accepting-modifications) | ||
- [Involving the Website Admin Group](#involving-the-website-admin-group) | ||
|
||
This document contains information for Collaborators of the Node.js | ||
website project regarding maintaining the code, documentation and issues. | ||
|
||
Collaborators should be familiar with the guidelines for new | ||
contributors in [CONTRIBUTING.md](./CONTRIBUTING.md) and also | ||
understand the project governance model as outlined in | ||
[GOVERNANCE.md](./GOVERNANCE.md). | ||
|
||
## Issues and Pull Requests | ||
|
||
Courtesy should always be shown to individuals submitting issues and | ||
pull requests to the Node.js website project. | ||
|
||
Collaborators should feel free to take full responsibility for | ||
managing issues and pull requests they feel qualified to handle, as | ||
long as this is done while being mindful of these guidelines, the | ||
opinions of other Collaborators and guidance of the Website Admin Group. | ||
|
||
Collaborators may **close** any issue or pull request they believe is | ||
not relevant for the future of the Node.js project. Where this is | ||
unclear, the issue should be left open for several days to allow for | ||
additional discussion. Where this does not yield input from Node.js | ||
Collaborators or additional evidence that the issue has relevance, the | ||
issue may be closed. Remember that issues can always be re-opened if | ||
necessary. | ||
|
||
## Accepting Modifications | ||
|
||
All modifications to the Node.js code and documentation should be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Node.js website code? |
||
performed via GitHub pull requests. Only the `Website Admin` group | ||
can merge their own work and should do so with great care. | ||
|
||
All pull requests must be reviewed and accepted by a Collaborator with | ||
sufficient expertise who is able to take full responsibility for the | ||
change. In the case of pull requests proposed by an existing | ||
Collaborator, an additional Collaborator is required for sign-off. | ||
|
||
In some cases, it may be necessary to summon a qualified Collaborator | ||
to a pull request for review by @-mention. | ||
|
||
If you are unsure about the modification and are not prepared to take | ||
full responsibility for the change, defer to another Collaborator. | ||
|
||
Before landing pull requests, sufficient time should be left for input | ||
from other Collaborators. Leave at least 48 hours during the week and | ||
72 hours over weekends to account for international time differences | ||
and work schedules. Trivial changes (e.g. those which fix minor bugs | ||
or improve performance without affecting API or causing other | ||
wide-reaching impact) may be landed after a shorter delay. | ||
|
||
Where there is no disagreement amongst Collaborators, a pull request | ||
may be landed given appropriate review. Where there is discussion | ||
amongst Collaborators, consensus should be sought if possible. The | ||
lack of consensus may indicate the need to elevate discussion to the | ||
Website Admin Group for resolution (see below). | ||
|
||
All bugfixes require a test case which demonstrates the defect. The | ||
test should *fail* before the change, and *pass* after the change. | ||
|
||
All pull requests that modify executable code should be subjected to | ||
continuous integration tests on the | ||
[project CI server](https://ci.nodejs.org/). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't CI on travis instead of jenkins here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there's also a jenkins thing that publishes the content in master. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah that makes sense There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
What is the website related stuff called? |
||
|
||
### Involving the Website Admin Group | ||
|
||
Collaborators may opt to elevate pull requests or issues to the admin group for | ||
discussion by mentioning `@nodejs/website-admin`. This should be done | ||
where a pull request: | ||
|
||
- has a significant impact on the codebase, | ||
- is inherently controversial; or | ||
- has failed to reach consensus amongst the Collaborators who are | ||
actively participating in the discussion. | ||
|
||
The Website Admin group should serve as the final arbiter where required. | ||
|
||
## Developer's Certificate of Origin 1.0 | ||
|
||
By making a contribution to this project, I certify that: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nodejs.org?