Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.2 prep #562

Merged
merged 46 commits into from
Mar 26, 2024
Merged

Release 1.4.2 prep #562

merged 46 commits into from
Mar 26, 2024

Conversation

RedLeader962
Copy link
Collaborator

@RedLeader962 RedLeader962 commented Mar 22, 2024

Summary:

  • CI related mod for multi-architecture build on NorLab build system
  • Add support for Ubuntu Jammy
  • Fix running test with cmake flag debug
  • Update submodule version to latest release
  • Various repository management fix

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check README.md #Contributing
    for local testing procedure using libpointmatcher-build-system)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: master)
    and the release branch.

RedLeader962 and others added 30 commits January 8, 2024 16:02
…ry` [NMO-442]

- move contributing instructions to a contributing_instructions.md file
- move commit_msg_reference.md to `doc/contributing directory`
- change remaining ethz-asl domain reference to norlab-ulaval
- main `README.MD`
   - move the summary up, under the top banner
   - add missing installer script instructions
   - add docker image usage instructions
- Also muted the generate doc flag until UseDoxygen.cmake line 112 is fixed
…ease-logic-NMO-469

Add dockerhub release logic and improve main readme
Update .gitingore with auto-generated patterns for C++, Python, JetBrains IDEs ,and VSCode
- update build matrix
- update supported version in main doc, ubuntu install doc and contributing instructions
- update submodule to latest
- update jetbrains local run configuration
…b-icp-mapper [NMO-508]

Problem: It was crashing the build under ubuntu jammy
…-to-build-matrix-NMO-508

build: add ubuntu jammy to the repository suported version
@RedLeader962 RedLeader962 changed the title Mod docker compose services for running with docker-container driver Release 4.1.2 prep Mar 22, 2024
@RedLeader962 RedLeader962 changed the title Release 4.1.2 prep Release 1.4.2 prep Mar 22, 2024
Copy link
Collaborator

@simonpierredeschenes simonpierredeschenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job!

build_system/docker-compose.libpointmatcher.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@boxanm boxanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple places where the repo version is set to 1.4.0. Is it correct?

@RedLeader962
Copy link
Collaborator Author

Yes those are doc or test related. The doc ones are for example like fetching a previous release. The test one could point to any existing release. We won't increment those at each release. Also I'm going to deploy semantic-release workflow for the next release so that version increments in files be automated. We won't waist time with this anymore and its not error-prone contrary to doing it manually.

@RedLeader962
Copy link
Collaborator Author

@boxanm By the way if its ok with you, I recommend we discard the Sonarcloud Quality Gate failure (Duplication of new code). At this moment Sonarcloud purpose for us is for providing code insight, not as rule. We will comeback to that issue eventually.

@RedLeader962 RedLeader962 merged commit 1d735ad into master Mar 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants