Sunset google analytics #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jarrodmillman
force-pushed
the
sunset-google-analytics
branch
from
4dcd32b
to
f615f8b
Compare
InessaPawson
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
@jarrodmillman Looks good. Thank you for taking care of this!
rgommers
reviewed
Aug 8, 2022
| <link rel="alternate" hreflang="{{ .Language.Lang }}" href="{{ .RelPermalink }}" title="{{ .Language.LanguageName }}" /> | ||
| {{ end }} | ||
| {{ end }} | ||
| {{ template "_internal/twitter_cards.html" . }} |
There was a problem hiding this comment.
Just checking: we don't need this anymore? It's unrelated to analytics, and IIRC this was a deliberate fix at some point.
There was a problem hiding this comment.
Looking into it. If needed, I will fix this in the theme.
This was referenced Aug 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #550
Brief description of what is fixed or changed