Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twitter cards #191

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Aug 8, 2022

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f53e026
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/62f106e806a2f100096d9304
😎 Deploy Preview https://deploy-preview-191--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jarrodmillman
Copy link
Member Author

jarrodmillman commented Aug 8, 2022

I am not sure if this worked. Before
screenshot

Clearly, no card found. Now, we get
screenshot

It says the card was loaded successfully, but it is still "Unable to render Card preview". The source now includes

    <meta name="twitter:card" content="summary_large_image"/>
<meta name="twitter:image" content="https://theme.scientific-python.org/images/logo.svg"/>

<meta name="twitter:title" content="Scientific Python Hugo Theme documentation"/>
<meta name="twitter:description" content="Documentation &amp; template site for the Scientific Python Hugo Theme."/>

which seems correct.

I will merge and see if maybe it is an issue with it being a preview somehow...

@jarrodmillman jarrodmillman merged commit 50e5a61 into scientific-python:main Aug 8, 2022
@jarrodmillman jarrodmillman deleted the twitter-card branch August 8, 2022 12:58
@jarrodmillman jarrodmillman added this to the 0.1 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant