Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add SVG support for logos #1646

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

ldericher
Copy link
Contributor

This is my proposal to use an SVG as .Site.Params.Logo.

Additions, hints and corrections are welcome!

@ldericher
Copy link
Contributor Author

I can see my PR will not handle .Site.Params.SecondaryLogo correctly as it is replaced using JS in

elems = document.querySelectorAll("img.logo")

This might be irrelevant aka. "you should create a reactive SVG using CSS in that case"

@nunocoracao nunocoracao merged commit c3f3980 into nunocoracao:dev Aug 10, 2024
2 checks passed
@ldericher
Copy link
Contributor Author

Appreciate the merge, but this was WIP and I'm gonna propose another change instead. Rationale:

  1. This does not handle the "secondary" logo at all ie. breaks the parameter.
  2. The raw SVG logo data will be injected into every HTML file, therefore will not be cached!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants