Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "✨ add SVG support for logos" #1680

Closed
wants to merge 1 commit into from
Closed

Revert "✨ add SVG support for logos" #1680

wants to merge 1 commit into from

Conversation

ldericher
Copy link
Contributor

Reverts #1646

Rationale:
1. This does not handle the "secondary" logo at all ie. breaks the parameter.
2. The raw SVG logo data will be injected into every HTML file, therefore will not be cached!

⚠️ Please do not merge yet, this is WIP ⚠️

@ldericher
Copy link
Contributor Author

Question: What do the width and height params on the original img.logo DOM element even do that isn't already done in CSS?

@nunocoracao
Copy link
Owner

@ldericher I don't remember would need to review the source

@nunocoracao
Copy link
Owner

@ldericher I am closing this PR as it is not ready to merge. Please work off your branch and open the PR once it's ready to merge. If you need help let's use the respective issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldericher @nunocoracao