-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique week check in formatNumericWeeks #3677
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel. @nusmodifications first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3677 +/- ##
==========================================
+ Coverage 53.60% 53.62% +0.01%
==========================================
Files 272 272
Lines 5977 5979 +2
Branches 1428 1428
==========================================
+ Hits 3204 3206 +2
Misses 2773 2773 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll create a new issue to add warnings in our scraper (so we notice these sorts of incorrectly-entered data if we want to let the departments know)
Context
#3648
Implementation
TimetableCell
formatNumericWeeks
does a check to ensure listed weeks are unique. Also update condition for change in week <= 1 insteadOther Information
Instead of simply ensuring unique, should we also sort the weeks and maintain the <= 1 condition?