Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique week check in formatNumericWeeks #3677

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jloh02
Copy link
Member

@jloh02 jloh02 commented Mar 20, 2024

Context

#3648

Implementation

TimetableCell
formatNumericWeeks does a check to ensure listed weeks are unique. Also update condition for change in week <= 1 instead

Other Information

Instead of simply ensuring unique, should we also sort the weeks and maintain the <= 1 condition?

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:54am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:54am

Copy link

vercel bot commented Mar 20, 2024

@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.62%. Comparing base (711a6da) to head (eba7f1b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
+ Coverage   53.60%   53.62%   +0.01%     
==========================================
  Files         272      272              
  Lines        5977     5979       +2     
  Branches     1428     1428              
==========================================
+ Hits         3204     3206       +2     
  Misses       2773     2773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kokrui kokrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll create a new issue to add warnings in our scraper (so we notice these sorts of incorrectly-entered data if we want to let the departments know)

@kokrui kokrui merged commit be22c79 into nusmodifications:master Mar 27, 2024
6 checks passed
@jloh02 jloh02 deleted the fix/repeated-week-num branch April 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants