fix(timetable): add unique week check in formatNumericWeeks (#3677)

Co-authored-by: Kok Rui Wong <kokruiwong@gmail.com>
nusmodifications · Mar 27, 2024 · be22c79 · be22c79
1 parent 711a6da
commit be22c79
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/website/src/utils/timetables.ts b/website/src/utils/timetables.ts
@@ -484,7 +484,12 @@ function parseModuleConfig(serialized: string | string[] | null): ModuleLessonCo
  * - 1,2,3       => Weeks 1-3
  * - 1,2,3,5,6,7 => Weeks 1-3, 5-7
  */
-export function formatNumericWeeks(weeks: NumericWeeks): string | null {
+export function formatNumericWeeks(unprocessedWeeks: NumericWeeks): string | null {
+  // Ensure list of weeks are unique
+  const weeks = unprocessedWeeks.filter(
+    (value, index) => unprocessedWeeks.indexOf(value) === index,
+  );
+
   if (weeks.length === 13) return null;
   if (weeks.length === 1) return `Week ${weeks[0]}`;
 
@@ -509,7 +514,7 @@ export function formatNumericWeeks(weeks: NumericWeeks): string | null {
   };
 
   weeks.slice(1).forEach((next) => {
-    if (next - end === 1) {
+    if (next - end <= 1) {
       // Consecutive week number - keep going
       end = next;
     } else {