-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes somes context help issues in advanced settings panel. #12034
Conversation
Cc @feerrenrut, @LeonarddeR and @codeofdusk as authors of initial PR's and/or potential reviewers of future PRs. In the future, please do not forget context help when new controls are added in the GUI. |
Thanks @CyrilleB79, I have created a code review checklist to remind us of this and other similar forgotten tasks: #12037 |
Hmm, while it's a loss of consistency I think it is better not to include the category in the tag. Since we can't / don't want to change the name of these tags, then moving settings to new sections will result in a very confusing tag. It would be more sensible if the tag does not include the section name. The main reason I can see for wanting to include the section name is to ensure that the tag it is unique. Instead of a tag naming scheme, I'd propose an automated test. There isn't much we can do about the ones already in place, however I would like to also note that some of the "advanced settings" are quite likely to eventually graduate to another settings panel. |
Otherwise the changes look good. |
Yes, this makes sense. I have removed the category name from the tags of these 2 options that have not yet been included in any release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CyrilleB79
Link to issue number:
None
Summary of the issue:
In #12025 (superseding #11079) and in #11639, new options were added to the advanced settings panel and a dedicated paragraph was added to the user doc corresponding to each of them.
However, context help does not work for these options. I.e. when the focus is on one of this option, pressing F1 reports "No help available here".
This is due to 2 issues:
Description of how this pull request fixes the issue:
Testing performed:
Known issues with pull request:
None
Change log entry:
None: this PR only fixes issues that have not yet been released.