Skip to content

Commit

Permalink
Add missing context help. (PR #12034)
Browse files Browse the repository at this point in the history
* Fixes some missing context help in advanced settings panel.
  • Loading branch information
CyrilleB79 authored Feb 8, 2021
1 parent 068b181 commit a73b481
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions source/gui/settingsDialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2478,6 +2478,9 @@ class AdvancedPanelControls(
"""Holds the actual controls for the Advanced Settings panel, this allows the state of the controls to
be more easily managed.
"""

helpId = "AdvancedSettings"

def __init__(self, parent):
super().__init__(parent)
self._defaultsRestored = False
Expand Down Expand Up @@ -2581,6 +2584,7 @@ def __init__(self, parent):
pgettext("advanced.uiaWithChromium", "No"),
)
self.UIAInChromiumCombo = UIAGroup.addLabeledControl(label, wx.Choice, choices=chromiumChoices)
self.bindHelpEvent("ChromiumUIA", self.UIAInChromiumCombo)
self.UIAInChromiumCombo.SetSelection(config.conf["UIA"]["allowInChromium"])
self.UIAInChromiumCombo.defaultValue = self._getDefaultValue(["UIA", "allowInChromium"])

Expand Down Expand Up @@ -2628,6 +2632,7 @@ def __init__(self, parent):
"difflib"
)
self.diffAlgoCombo = terminalsGroup.addLabeledControl(diffAlgoComboText, wx.Choice, choices=diffAlgoChoices)
self.bindHelpEvent("DiffAlgo", self.diffAlgoCombo)
curChoice = self.diffAlgoVals.index(
config.conf['terminals']['diffAlgo']
)
Expand Down
2 changes: 1 addition & 1 deletion user_docs/en/userGuide.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ This feature is available and enabled by default on Windows 10 versions 1607 and
Warning: with this option enabled, typed characters that do not appear onscreen, such as passwords, will not be suppressed.
In untrusted environments, you may temporarily disable [speak typed characters #KeyboardSettingsSpeakTypedCharacters] and [speak typed words #KeyboardSettingsSpeakTypedWords] when entering passwords.

==== Diff algorithm ====[AdvancedSettingsDiffAlgo]
==== Diff algorithm ====[DiffAlgo]
This setting controls how NVDA determines the new text to speak in terminals.
The diff algorithm combo box has three options:
- Automatic: as of NVDA 2021.1, this option is equivalent to Difflib.
Expand Down

0 comments on commit a73b481

Please sign in to comment.