-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsats in HCAO caused by Uberon/CL terms #2749
Comments
I just checked, and http://purl.obolibrary.org/obo/CL_0000745 is not causing any unsats in the HCAO pipeline. |
From @dosumis
|
@JCGiron - I think this should be fixed in RO with this PR oborel/obo-relations#661 |
It worked!!! |
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken. |
Looks like this has been fixed. Please re-open if not. |
Uberon does not have the following disjoint:
bearer of some maximally connected DisjointWith bearer of some disconnected
which I do not think is problematic, but if you add that in (like HCAO does), a lot of unsats will appear (I assume).
Currently HCAO deals with this by removing the following classes:
http://purl.obolibrary.org/obo/UBERON_0000965 # lens of camera-type eye
http://purl.obolibrary.org/obo/UBERON_0003902 # retinal neural layer
http://purl.obolibrary.org/obo/CL_0000745 # retina horizontal cell (this should be fixed next release, it was using part of instead of has soma location)
However, we should probably look into getting this fixed on Uberons side.
see HumanCellAtlas/ontology#123 for details
I think it might come down to this:
and perhaps considering relaxing the domain of developmentally_induced_by would be the solution?
Would appreciate input from @cmungall & @dosumis
Tagging @bvarner-ebi & @anitacaron
The text was updated successfully, but these errors were encountered: