Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsats in HCAO caused by Uberon/CL terms #2749

Closed
shawntanzk opened this issue Dec 16, 2022 · 7 comments
Closed

Unsats in HCAO caused by Uberon/CL terms #2749

shawntanzk opened this issue Dec 16, 2022 · 7 comments
Labels

Comments

@shawntanzk
Copy link
Collaborator

Uberon does not have the following disjoint:

bearer of some maximally connected DisjointWith bearer of some disconnected

which I do not think is problematic, but if you add that in (like HCAO does), a lot of unsats will appear (I assume).

Currently HCAO deals with this by removing the following classes:

http://purl.obolibrary.org/obo/UBERON_0000965 # lens of camera-type eye
http://purl.obolibrary.org/obo/UBERON_0003902 # retinal neural layer
http://purl.obolibrary.org/obo/CL_0000745 # retina horizontal cell (this should be fixed next release, it was using part of instead of has soma location)

However, we should probably look into getting this fixed on Uberons side.

see HumanCellAtlas/ontology#123 for details

I think it might come down to this:

and perhaps considering relaxing the domain of developmentally_induced_by would be the solution?

Would appreciate input from @cmungall & @dosumis

Tagging @bvarner-ebi & @anitacaron

@shawntanzk shawntanzk assigned shawntanzk and ghost Dec 16, 2022
@anitacaron
Copy link
Collaborator

I just checked, and http://purl.obolibrary.org/obo/CL_0000745 is not causing any unsats in the HCAO pipeline.

@shawntanzk
Copy link
Collaborator Author

From @dosumis

I don’t understand why we’ve ended up with ‘connected’ vs ‘disconnected’ as a distinction we care about for domain and range of anatomical relations. Relaxing these, and probably others to ‘material anatomical entity’ makes sense to me.

@JCGiron
Copy link

JCGiron commented Jan 17, 2023

Piling up on this on unsatisfiable classes:
I added new terms to AISM and tried to run a release using the ODK.
I got errors: 174 unsatisfiable classes where all are from terms imported from UBERON, GO, and CL. Most of the UBERON terms are vertebrate-specific and do not apply to insects, so we don't really need them, but they are there, making thins difficult.

Below is the result from sh run.sh make explain_unsat:

corneal epithelial cell SubClassOf Nothing

smooth muscle cell of sphincter of pupil SubClassOf Nothing

keratocyte SubClassOf Nothing

retinal cone cell SubClassOf Nothing

vertebrate lens cell SubClassOf Nothing

choroidal cell of the eye SubClassOf Nothing

scleral cell SubClassOf Nothing

retinal ganglion cell SubClassOf Nothing

lens epithelial cell SubClassOf Nothing

retinal rod cell SubClassOf Nothing

Axiom Impact

Axioms used 10 times

Axioms used 9 times

Axioms used 5 times

Axioms used 2 times

Axioms used 1 times

Ontologies used:

Please help!
@balhoff @shawntanzk

@shawntanzk
Copy link
Collaborator Author

@JCGiron - I think this should be fixed in RO with this PR oborel/obo-relations#661
Could you try refreshing your RO import and checking again?
I see this:
developmentally induced by Domain anatomical structure
which should have been fixed to having the domain be CARO:0000006

@JCGiron
Copy link

JCGiron commented Jan 18, 2023

It worked!!!
Thank you, @shawntanzk !!

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Sep 24, 2023
@dosumis
Copy link
Contributor

dosumis commented Oct 19, 2023

Looks like this has been fixed. Please re-open if not.

@dosumis dosumis closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants