Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax range and domain on RO:0002256 #661

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

shawntanzk
Copy link
Collaborator

@shawntanzk shawntanzk commented Jan 3, 2023

see obophenotype/uberon#2749

relation: 'developmentally induced by'

@shawntanzk shawntanzk self-assigned this Jan 3, 2023
@dosumis
Copy link
Contributor

dosumis commented Jan 3, 2023

Please use 'material anatomical entity' rather than just 'anatomical entity'. I don't think it makes sense for an 'immaterial anatomical entity' to induce anything.

In CARO this is http://purl.obolibrary.org/obo/CARO_0000006 - but @cmungall should we be switching these to Uberon?

@shawntanzk
Copy link
Collaborator Author

Please use 'material anatomical entity' rather than just 'anatomical entity'. I don't think it makes sense for an 'immaterial anatomical entity' to induce anything.

Ah you're right didn't think about immaterial anatomical entities, will make the change :)

@shawntanzk
Copy link
Collaborator Author

In RO call we decided to handle this asynchronously. I see that David has given the thumbs up so I will go ahead and merge this, please do open another ticket if you have concerns (relaxing wont break anything, so we can always tighten if need be without any pipelines breaking).
Sorry for the rush, planning to make a RO release soon to fix unsats :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants